fix: Position mobile menu above footer using CSS #1363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the issue with the mobile menu in LayoutMobileMenu.vue by implementing a CSS-based solution to position the menu above the footer. The changes include: Remove JavaScript-based height calculations Add CSS positioning for the mobile menu to prevent footer overlap Simplify component logic for toggling menu visibility Ensure menu is scrollable when content exceeds available height Maintain proper opening and closing functionality The mobile menu now extends from the top of the screen to just above the footer, allowing users to close it by clicking the hamburger icon or selecting a menu item. The footer remains visible and accessible at all times. Note: The CSS values for bottom spacing and max-height may need adjustment based on the actual footer height in the application. This fix improves the user experience by ensuring the mobile menu is always accessible and doesn't interfere with the footer content.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the issue with the mobile menu in LayoutMobileMenu.vue by implementing a CSS-based solution to position the menu above the footer. The changes include:
Remove JavaScript-based height calculations
Add CSS positioning for the mobile menu to prevent footer overlap Simplify component logic for toggling menu visibility Ensure menu is scrollable when content exceeds available height Maintain proper opening and closing functionality
The mobile menu now extends from the top of the screen to just above the footer, allowing users to close it by clicking the hamburger icon or selecting a menu item. The footer remains visible and accessible at all times.
Note: The CSS values for bottom spacing and max-height may need adjustment based on the actual footer height in the application.
This fix improves the user experience by ensuring the mobile menu is always accessible and doesn't interfere with the footer content.